Fix tab completion of paths in CDPATH, fixes #1374

[joshingly]

#1374

[mpapis]

I thought it was unset to fix something, but it should be also resotred after out of rvm, so the completion which is done in shell should work - so the bug might be not that we unset it - but rather that we do not restore it properly

[richo]

When you say tab completion is broken, is actually using CDPATH also broken?

AFAIK cdpath is restored properly.

[mpapis]

are you using rvm_cd_complete_flag=1?

[joshingly]

rvm_cd_complete_flag is set and the issue is still present. CDPATH appears to be restored properly (echoing CDPATH returns the correct value), using CDPATH (without tab completion) still works.

[richo]

can you rvm get head and let me know if this is still an issue?

[mpapis]

I was thinking more of ${CDPATH:-$rvm_stored_cdpath} in here https://github.com/wayneeseguin/rvm/blob/master/scripts/cd#L81-L86

[joshingly]

Did an rvm get head and everything is working now... thanks!

[mpapis]

@Antonishen so can we close both tickets?

[joshingly]

@mpapis done and done! thanks for your help!

[richo]

You're right though @mpapis I hadn't seen that we exported a cd hook for bash.

My fix just relies on the vague quirks in bash/zsh when you unset magic variables, for example unset RANDOM breaks random forever

[mpapis]

ah ok, so I think we should replace all $CDPATH with ${rvm_stored_cdpath:-$CDPATH} in here -> https://github.com/wayneeseguin/rvm/blob/master/scripts/cd#L81-L86

[mtylty]

I just went with rvm get head and the issue is fixed at first (when logging into a new terminal).

As soon as I cd into a repo with a proper .rvmrc (setting a per project gemset), my $CDPATH has changed to just .

[mpapis]

my guess is we do not initialize rvm_stored_cdpath on every call, it's set only when rvm is loaded, @mtylty please open a new ticket (I can not reopen pull request)