Remove incompatible version of openssl098 #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapis
reviewed
Jan 1, 2017
| Check Homebrew requirements https://github.com/Homebrew/homebrew/wiki/Installation" | ||
| } | ||
|
|
||
| } |
| @@ -290,6 +311,8 @@ requirements_osx_brew_libs_default() | |||
|
|
|||
| requirements_osx_brew_check_custom homebrew/dupes # for: zlib | |||
|
|
|||
| undesired_check openssl098 | |||
There was a problem hiding this comment.
not sure it should be in custom or rather in before or define? or maybe we should add before_install? or even a new step uninstall? - if custom is called always - just leave it :)
There was a problem hiding this comment.
Yeah, the requirements_osx_brew_libs_default is called in few places, that's why I put it there. Not sure if we should have a dedicated uninstall function. Possibly. Didn't want to invest too much of the time having RVM2 down the road...
…openssl098 # Conflicts: # CHANGELOG.md
Signed-off-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3844
Uses #3855