-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install from tag #4360
Add install from tag #4360
Conversation
pending pull url
@mpapis ? |
all is fine, but wouldn't it be better to fix |
Seems to be two totally different things - `rvm_ruby_tag` is basically the "version" of a ruby; `rvm_ruby_repo_tag` is tag in the `git` sense (i.e. a nickname for a particular commit).
There's no guarantee that rubies will be stored in git repos or have git tags to mark their releases. Nor will all git tags be releases.
I tried to make a minimal change so as to *not* mess with the `rvm_ruby_tag` code. :-P
|
|
||
__rvm_unset_ruby_variables | ||
|
||
rvm_ruby_repo_url="${repo_url:-}" | ||
rvm_ruby_repo_branch="${branch_name:-}" | ||
rvm_ruby_name="$ruby_name" | ||
rvm_ruby_repo_tag="${rvm_ruby_repo_tag:-}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rvm_ruby_repo_tag="${tag_name}"
@@ -248,6 +263,8 @@ __rvm_fetch_from_git_revision_or_sha() | |||
then __from="${rvm_ruby_sha}" | |||
elif [[ -n "${rvm_ruby_repo_branch:-}" ]] | |||
then __from="${rvm_ruby_repo_branch}" | |||
elif [[ -n "${rvm_ruby_repo_tag:-}" ]] | |||
then __from="${rvm_ruby_repo_tag}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how this is different from the earlier line __from="${rvm_ruby_tag#t}"
? why can't we use that?
rvm_ruby_tag is the "name" of a release for display purposes. It may or
may not be stored as a git tag in the repo.
rvm_ruby_repo_tag (what I added) is specifically a git tag. It may or may
not be a release.
|
but they both end up in the |
In other parts, it makes a difference — e.g. the gem name & pulling the tag description from git. Or going around the tag-as-in-name lookup and just doing tag-as-in-git. |
Fixes #4312.
Changes proposed in this pull request:
--tag
torvm install