-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready] Fixed script objects falling through the ground #450
Conversation
After the fix, some hydrants dont break when u hit with the car(high speed) but when u give small hits near the hydrant he breaks, its normal ? |
I'll test |
What you described happens in master branch, in my branch hydrants don't even break |
@@ -308,7 +308,8 @@ void ObjectRenderer::renderVehicle(VehicleObject* vehicle, | |||
void ObjectRenderer::renderPickup(PickupObject* pickup, RenderList& outList) { | |||
if (!pickup->isEnabled()) return; | |||
|
|||
glm::mat4 modelMatrix = glm::translate(glm::mat4(1.0f), pickup->getPosition()); | |||
glm::mat4 modelMatrix = | |||
glm::translate(glm::mat4(1.0f), pickup->getPosition()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's just formatting changes in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getVisible was placed with isVisible
RW_UNUSED(args); | ||
object->setStatic(!arg2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of this opcode seems to be that it turns collision detection on and off, not change static status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You right. Will fix.
This fixes issue when during the game intro few objects fall through the ground.
Issues to fix: