Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed advanced DataSource Filters to use proper logic tokens #18

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

dandrayan
Copy link
Collaborator

Filtering did not work properly with more complex filters because the logic token from the top level was always being used, ignoring any logic tokens at the child level. I added a page to the examples project to demonstrate these fixes.

Sorry for the large number of file changes, I couldn't get the model binder to work with MVC3 so I updated to MVC4 (and had to update lots of dependencies too because of it). The important changes are in the KendoGridRequest and FilterObject files.

@rwhitmire
Copy link
Owner

Not a problem. I'm going to blindly merge this since you brought the project dependencies into the modern era. I'll add you to the project too since I do zero work with Kendo and MVC these days.

Thanks!

rwhitmire added a commit that referenced this pull request Aug 6, 2015
Fixed advanced DataSource Filters to use proper logic tokens
@rwhitmire rwhitmire merged commit 5b26afb into rwhitmire:master Aug 6, 2015
@StefH
Copy link
Collaborator

StefH commented Aug 6, 2015

Hi @dandrayan. Can you please check if my updated fork https://github.com/StefH/KendoGridBinderEx does also have this issue?

@dandrayan
Copy link
Collaborator Author

@StefH Your project looks good. KendoGrid.cs line 231 and KendoGridEx.cs line 310 both use the correct LogicToken. Now that I know your project exists, I may use it instead since it has the grouping and aggregates fully fleshed out. Thank you both for the hard work put into these projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants