Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Volume Slider doesn't close #30

Closed
rwieruch opened this issue May 26, 2017 · 1 comment
Closed

Bug: Volume Slider doesn't close #30

rwieruch opened this issue May 26, 2017 · 1 comment
Labels
bug help wanted

Comments

@rwieruch
Copy link
Owner

The Volume Slider that is attached to the Player in the bottom doesn't close when the Player closes. However, that should be the case. It should be the same as the Playlist that is attached to the Player which disappears when the Player disappears.

screen shot 2017-05-26 at 10 29 22
@chriszhangusc chriszhangusc mentioned this issue Jun 6, 2017
Merged
rwieruch added a commit that referenced this issue Jun 6, 2017
@rwieruch
Merge pull request #39 from MiniPekka/hotfix/#30
43e4b37 
Fix the volume slider not closing when player closes
@rwieruch
Copy link
Owner Author

rwieruch commented Jun 6, 2017

Fixed in #39 by @minipekka 🎉

@rwieruch rwieruch closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwieruch