Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement login redirect for dashboard page #76

Merged
merged 1 commit into from Oct 30, 2017
Merged

Implement login redirect for dashboard page #76

merged 1 commit into from Oct 30, 2017

Conversation

chriszhangusc
Copy link
Collaborator

  1. Redirect to the home page when trying to access dashboard page without authentication.
  2. Redirect to the home page when login is canceled by the user or failed for whatever reasons.

@rwieruch
Copy link
Owner

That sounds perfect @minipekka Thanks for improving/fixing it! I didn't test it, but I believe you did, so I will just merge it 👍

@rwieruch rwieruch merged commit d8669dc into rwieruch:master Oct 30, 2017
@chriszhangusc
Copy link
Collaborator Author

@rwieruch I double checked just in case, and I found a bug..... Sorry I failed you haha. I will make a patch for it.

@chriszhangusc
Copy link
Collaborator Author

#78 I will create some tests for the newly added code. Also, I think it might be a good idea to also update the sister project to keep things in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants