Revert "ENH: replace star imports with imported names in train.py" #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaczmarj oy, hmm.. how about leave loss explicit as is, and import timm.utils as utils ... and then use |
|
good idea, i'll make a pr for that. thanks for your quick response. |
kaczmarj
added a commit
to kaczmarj/pytorch-image-models
that referenced
this pull request
May 26, 2022
This fixes buggy behavior introduced by huggingface#1266. Related to huggingface#1273.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1266
hi @rwightman - #1266 introduces potentially unwanted behavior. if the current version of
train.pywith the current release oftimm, then anImportErroris raised because ofset_jit_fuser(added in f0f9ecc).one solution is to revert #1266. or if this is not a problem for you, we can leave this (and we can close this pr). i wanted to document this behavior here.