MDL-25186: add environmental check to recommend PHP 5.3.3

rwijaya · Dec 23, 2010 · 0595189 · 0595189
1 parent 0300e58
commit 0595189
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/admin/environment.xml b/admin/environment.xml
@@ -321,6 +321,11 @@
       </PHP_SETTING>
     </PHP_SETTINGS>
     <CUSTOM_CHECKS>
+        <CUSTOM_CHECK file="lib/customcheckslib.php" function="php_check_php533" level="optional">
+        <FEEDBACK>
+          <ON_CHECK message="php533warning" />
+        </FEEDBACK>
+      </CUSTOM_CHECK>
     </CUSTOM_CHECKS>
   </MOODLE>
 </COMPATIBILITY_MATRIX>
diff --git a/lang/en_utf8/admin.php b/lang/en_utf8/admin.php
@@ -588,6 +588,7 @@
 $string['pgcluster'] = 'PostgreSQL Cluster';
 $string['pgclusterdescription'] = 'PostgreSQL version/cluster parameter for command line operations. If you only have one postgresql on your system or you are not sure what this is, leave this blank.';
 $string['php50restricted'] = 'PHP 5.0.x has a number of known problems, please upgrade to 5.1.x or downgrade to 4.3.x or 4.4.x';
+$string['php533warning'] = 'PHP 5.3.3 and upwards is recommended';
 $string['phpfloatproblem'] = 'Detected unexpected problem in handling of PHP float numbers - $a';
 $string['pleaseregister'] = 'Please register your site to remove this button';
 $string['pleaserefreshregistration'] = 'Your site has been registered with moodle.org, please consider updating the registration if significant changes happened since your last update, on $a';

diff --git a/lib/customcheckslib.php b/lib/customcheckslib.php
@@ -54,4 +54,12 @@ function php_check_register_globals($result) {
     return $result;
 }
 
+function php_check_php533($result) {
+    if (version_compare(phpversion(), '5.3.3') < 0) {
+        $result->status = false;
+    } else {
+        $result = null;
+    }
+    return $result;
+}
 ?>