Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the correct ember-template-recast command is found for template based codemods #156

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Ensure the correct ember-template-recast command is found for template based codemods #156

merged 2 commits into from
Feb 17, 2021

Conversation

zhanwang626
Copy link
Contributor

Description

Fix issue 155. Change the bin entry for ember-template-recast for better compatibility.

Test

# pass 23
# skip 0
# todo 0
# fail 0
✨  Done in 69.59s.

rwjblue
rwjblue approved these changes Feb 17, 2021
View reviewed changes
Copy link
Owner

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

rwjblue
rwjblue requested changes Feb 17, 2021
View reviewed changes
src/bin-support.js Outdated Show resolved Hide resolved
@zhanwang626 @rwjblue
Update src/bin-support.js
8f2ce8e 
Co-authored-by: Robert Jackson <me@rwjblue.com>
@rwjblue rwjblue merged commit 9ba5660 into rwjblue:master Feb 17, 2021
@rwjblue rwjblue added the bug Something isn't working label Feb 17, 2021
@rwjblue rwjblue changed the title fix the break when running ember-template-recast Ensure the correct ember-template-recast command is found for template based codemods Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility with ember-template-recast v5
2 participants
@zhanwang626 @rwjblue