Removes input suffix from the path indicated during a test
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make writing accurate tests much easier. Possibly breaking.
|
Can you explain more what the goal is here? |
|
This was something we meant to do a while back, in the native class codemod the codemod actually relies on the filepath for naming classes correctly. We were trying to update things to work for pods effectively, and we couldn't actually test things accurately since the test names didn't match up with reality: ember-codemods/ember-native-class-codemod#52 (comment) |
rwjblue
changed the title
input suffix from the path indicated during a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make writing accurate tests much easier. Possibly breaking.