Update CLI command to support config from config/content-security-policy.js and fall back to legacy config/environment.js config.
#103
Conversation
jelhan
force-pushed
the
issue-98-cli-command-is-not-using-new-configuration
branch
from
91975fc
to
f393e84
Compare
jelhan
force-pushed
the
issue-98-cli-command-is-not-using-new-configuration
branch
from
c7c275c
to
05a5a79
Compare
|
Rebased on top of #105. Should be ready as soon as that one is merged. |
jelhan
force-pushed
the
issue-98-cli-command-is-not-using-new-configuration
branch
from
05a5a79
to
9168668
Compare
jelhan
changed the title
|
Rebased on top of master. @rwjblue ready to be merged from my side. |
jelhan
force-pushed
the
issue-98-cli-command-is-not-using-new-configuration
branch
from
9168668
to
d9ddc5e
Compare
|
Rewritten commit history so that #91 is not blocked anymore by this one but shares a commit with it. |
jelhan
force-pushed
the
issue-98-cli-command-is-not-using-new-configuration
branch
from
d9ddc5e
to
4c2606a
Compare
|
@rwjblue Rebased. Not sure what happened with Travis CI. Seems like it created five builds. Four seem to be stale. But should be safe to merge cause one passed. |
| readConfig | ||
| } = require('./utils'); | ||
|
|
||
| const CSP_HEADER = 'Content-Security-Policy'; |
There was a problem hiding this comment.
Definitely non-blocking, and probably just a bit too nitpicky but in general I prefer to avoid the equals alignment stuff. It makes future changes change lines that are unrelated (e.g. when adding new variables with a slightly longer name), and then makes it just a tiny bit harder to follow whats going on through the git history.
There was a problem hiding this comment.
💯 I was just adopting the existing coding style.
rwjblue
changed the title
config/content-security-policy.js and fall back to legacy config/environment.js config.
Closes #98