Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with additional info. #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

conorluddy
Copy link

Hey Robert!
Thanks for this handy plugin. We're using it on a large scale Ember project at the moment and I was just digging in to see what data this can provide. I've updated the version of git-repo-info to the latest, updated the readme, and updated config/environment to provide the additional items that are now available.
Feel free to merge or ignore.

Many thanks,
Conor

Copy link
Owner

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit a PR for this (it looks great)!

After reading through the config/environment.js changes, I was thinking that it might be better to just slightly modify the return value from gitRepoInfo (to add currentRevision and longRevision) but just pass through the rest of the results. That would mean that any changes made upstream are automatically available here...

Was thinking something like:

module.exports = function() {
  var currentInfo = gitRepoInfo();

  currentInfo.currentRevision = currentInfo.abbreviatedSha;
  currentInfo.longRevision = currentInfo.sha;

  return currentInfo;
};

What do you think?

@conorluddy
Copy link
Author

No problem at all! Yeah that sounds good, and it's your baby so please change it however you like :)

@joankaradimov joankaradimov mentioned this pull request May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants