Converts the system to a token based system rather than arbitrary objects #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step2yeung
reviewed
May 12, 2019
step2yeung
approved these changes
May 12, 2019
rwjblue
requested changes
May 13, 2019
There was a problem hiding this comment.
I would have massively preferred this to be separate PRs, there are at least three independent things going on here:
- Dropping ember-qunit
- Adding the "auto generate token" functionality
- Adding a
resetmethod
This is generally important for a few reasons:
- It makes reviewing much easier, since it keeps distinct changes together
- It ensures that any changelog generator will properly report the changes separately (because all three things are possibly important to have listed in the changelog)
- It helps ensure each change is independently rationalized
|
@rwjblue you're right, this PR got absurdly large. I'll pull out the different bits into their own PRs. |
scalvert
force-pushed
the
convert-to-token
branch
from
b1480d9
to
430d795
Compare
|
Landed the dropping of ember-qunit over in #9 |
mike-north
reviewed
May 14, 2019
scalvert
force-pushed
the
convert-to-token
branch
from
430d795
to
a104081
Compare
scalvert
force-pushed
the
convert-to-token
branch
from
9b84ab0
to
a013a5f
Compare
rwjblue
requested changes
May 14, 2019
scalvert
force-pushed
the
convert-to-token
branch
from
26d8fef
to
71b109d
Compare
rwjblue
reviewed
May 14, 2019
rwjblue
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
TestWaiterclass to a token based system to maintain uniqueness between calls (beginAsyncandendAsynccalls can be paired, rather than the same object value being passed to all calls to waiters, which resulted in errors thrown if multipleendAsynccalls happened in a row)