Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node v10 #13

Merged
merged 1 commit into from
May 11, 2021
Merged

Drop support for node v10 #13

merged 1 commit into from
May 11, 2021

Conversation

hjdivad
Copy link
Collaborator

@hjdivad hjdivad commented May 11, 2021

No description provided.

@hjdivad hjdivad requested a review from rwjblue May 11, 2021 00:41
@hjdivad
Copy link
Collaborator Author

hjdivad commented May 11, 2021

@rwjblue LMK if you see any reason not to merge + release 2.0.0

@hjdivad
Copy link
Collaborator Author

hjdivad commented May 11, 2021

@rwjblue you might need to be the one to update protected branches.

@scalvert
Copy link
Collaborator

Unsure why this is trying to run the 10.x scenario, when it's been removed.

@hjdivad
Copy link
Collaborator Author

hjdivad commented May 11, 2021

@scalvert it's because the repo has it in protected branches. Protected branches are good, but this specific scenario is one where they kinda get in the way a bit.

@rwjblue rwjblue merged commit 38a5a99 into main May 11, 2021
@rwjblue rwjblue deleted the hjdivad/drop-10 branch May 11, 2021 17:44
hjdivad added a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants