Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Polls #181

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

Feature: Polls #181

wants to merge 45 commits into from

Conversation

Seneral
Copy link

@Seneral Seneral commented Feb 7, 2021 •
edited
Loading

Added Poll Functionality to Rooms

Polls can be:

  • accessed through the Menu
  • optionally saved with the project
  • recalled after loading the project

For more information on the feature see the wiki page

Additional changes:

  • Added Barchart2D only regarding the first two dataset columns
  • Added Barchart2DLabeled taking the third dataset column as labels that are displayed on hover over the bars
  • Added Fallback to ExtendedWilkinson when it fails (min==max) so that something is displayed
  • Added public function overload SceneNetworkInstantiate to ResourceManager allowing instantiation of room objects by name instead of object
  • Added behaviour to SaveLoadManager allowing instantiation of SerializedObjects as room objects when Bools["ROOM"]==true
  • Integration of window into MainMenu.cs and WindowManager.cs as well as the Managers.prefab and Main Menu.prefab

Togira-Ikonoka and others added 30 commits January 19, 2021 21:27
@Togira-Ikonoka
Basic Poll Functionality
591af0e
@Togira-Ikonoka
improved poll protocoll
f2c67bf
@Seneral
Added and integrated Poll UI
dee4e11 
Current State:
- UI Tested and working locally
- Photon Functionality untested
@Seneral
Fixes to UI integration and network
2659b06
@Seneral
Fixed prefabs
2a131e7
@Seneral
Added visualization and fixes
5ce73ca 
Restructure.

Fixed Countdown
Added (currently buggy) bar visualization
Added SingleChoice option
@Seneral
Code Formatting
2966c78
@Togira-Ikonoka
added missing Visualization fixed Countdown
d637e87
@Togira-Ikonoka
added missing Visualization fixed Countdown
8bd7929
@cmck-xyz
Merge branch 'feature/poll-dev' of https://github.com/rwth-acis/VIAProMa
f7b5de1 
 into feature/poll-dev
@Seneral
Networking fixes and documentation
c61fc73 
Added code documentation (closes #165)
Added test scene PollTest.unity (closes #159)

Made Poll UI follow User (closes #162)

Fixed invalid state and networking when poll concludes early (fixes #160)
@cmck-xyz
Merge branch 'feature/poll-dev' of https://github.com/rwth-acis/VIAProMa
ef39eb1 
 into feature/poll-dev
@cmck-xyz
Added 2D Barchart and related functionality
c22c6f0
@Seneral
Restored unrelated files
24bf6f3
@Togira-Ikonoka
Improved Poll Visualization
c183372 
Use 2D Diagram prefab
in Poll Barcgart 2D Viz prefab use non configuration App Bar
@Seneral
Added Countdown timer and fixes
f3285eb 
Added local countdown timer (closes #158)
Fixed barchart min!=max (fixes #167)
@Togira-Ikonoka
Better Spawnposition for Poll Bar Chart
41ddc22 
Now spawns infront of the user with a configurable horizontal distance
Closes #168
@Seneral
Merge pull request #169 from rwth-acis/feature/poll-dev
9c25bb1 
The core functionality is working and tested.
@Togira-Ikonoka
Initial Setup for saving polls
2304918
@Togira-Ikonoka
Added Save Option to poll creation
4c8dfb4 
fixed Errors
@Togira-Ikonoka
saving and loadin polls in project
f5d1e25 
cleaning up list of saved polls
@Togira-Ikonoka
restructured and tested saving
16bc9cf
@Togira-Ikonoka
added loading of saved polls
98f941c 
todo: better looking object, poll shelf position
@Togira-Ikonoka
Paging and start populating at the top shelfboard
9cc8fc1
@Seneral
Fixed, tested and polished SaveLoad
f135ffa
@Togira-Ikonoka
Merge pull request #176 from rwth-acis/feature/poll-dev-saveloadsystem
5716ba8 
Added Save Load System for poll results
@Seneral
Added Voter display for public polls
01a2e6a 
Public/Anonymous votes can be toggled on poll creation
Voters are displayed on the bar chart by hovering over columns
Icons in selection panel now show if poll is public and if results are saved
Removed obvious clutter labels from Poll barchart
@Togira-Ikonoka
Added button to stop poll early
0cb9698 
fixed local state to have 1 active poll per room
Cleared state if poll host leaves

LogMissingReferenceError
@Togira-Ikonoka
display poll question
5884484
@Seneral
First synchronized Visualizations
f738e27 
Added synchronized visualizations, only created by one client
Synced by index into seperately synchronized database
Seneral and others added 15 commits February 6, 2021 22:37
@Seneral
Fixed Synchronization
5847702
@Seneral
Synchronization fixes
3d64fa0
@Seneral
Big red beautiful button
081fe44
@Seneral
Added Realtime Visualization
c09bc90
@Seneral
Fixed two errors
185fb3c
@Seneral
Fixed more errors
454439b
@Seneral
Final fixes to realtime viz and sync
05228cf
@Togira-Ikonoka
Merge pull request #179 from rwth-acis/feature/poll-dev-realtimesync
9899d45 
Feature/poll dev realtimesync
@Seneral
Consistent formatting
f334072
@Seneral
Restored file that was unintentionally deleted
191b03e
@Togira-Ikonoka
Changed handling of PollSerializer Object
136be00 
Extended SaveLoad System for Room Objects
Added public function for room object instantiation by name
Join running polls on room join
Comments and Cleanup
@Togira-Ikonoka
fixed typo
d80572f
@Togira-Ikonoka
Fixed Loading to synchronize poll lists
9ebf13d
@Togira-Ikonoka
Consitent bar coloring
332e01d 
nullref fix
@Seneral
Merge pull request #180 from rwth-acis/feature/poll-dev
32cb2c1 
Feature/poll dev
@Seneral Seneral added the enhancement New feature or request label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmck-xyz cmck-xyz

@Seneral Seneral

@Togira-Ikonoka Togira-Ikonoka

@SteffenKrger SteffenKrger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seneral @cmck-xyz @Togira-Ikonoka @SteffenKrger