Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Icons on Palette widget #72

Closed
lakhoune opened this issue Dec 7, 2022 · 1 comment
Closed

Fix Icons on Palette widget #72

lakhoune opened this issue Dec 7, 2022 · 1 comment
Labels
yjs13
Milestone
Yjs 13

Comments

@lakhoune
Copy link
Member

lakhoune commented Dec 7, 2022

As it seems to be, the customIcons are broken on the new version.
This is due to the fact that we are now serving a static dir and the paths for the images are generated on runtime when a new metamodel is added.
@lakhoune lakhoune added the yjs13 label Dec 7, 2022
@lakhoune
Copy link
Member Author

lakhoune commented Dec 7, 2022

I noticed that the icons in the cavas show up though. On further inspection, I saw that thats because they are SVGs that are coming from (im guessing) the meta model itself.
We should be able to also reuse those for the palette as well.

@lakhoune lakhoune added this to the Yjs 13 milestone Dec 7, 2022
lakhoune added a commit that referenced this issue Dec 7, 2022
@lakhoune
Fix Icons on Palette widget #72
46895a1
lakhoune added a commit that referenced this issue Dec 26, 2022
@lakhoune
closes #72
3c50da0
lakhoune added a commit that referenced this issue Dec 27, 2022
@lakhoune
Fix Icons on Palette widget #72
d45d34e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
yjs13
Projects
None yet
Milestone
Yjs 13
Development

No branches or pull requests
1 participant
@lakhoune