Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking feature does not actually work #31

Closed
rwz opened this issue Dec 20, 2014 · 6 comments · Fixed by #34
Closed

Locking feature does not actually work #31

rwz opened this issue Dec 20, 2014 · 6 comments · Fixed by #34
Assignees
@rwz
Labels
bug

Comments

@rwz
Copy link
Collaborator

rwz commented Dec 20, 2014

The reason: ember-cli/ember-cli#2792

The pre-build step we're relying on for creating a lockfile was actually firing AFTER the build process. Will be fixed in ember-cli 0.1.5
@rwz rwz added the bug label Dec 20, 2014
@rwz rwz self-assigned this Dec 20, 2014
@rondale-sc
Copy link
Collaborator

EmberCLI fixed here: ember-cli/ember-cli#2792

@rwjblue
Copy link
Contributor

rwjblue commented Dec 21, 2014

Sorry about the bug y'all. Gonna try to get 0.1.5 out in the next couple days so hopefully it won't be too bad...

@rwjblue
Copy link
Contributor

rwjblue commented Dec 21, 2014

Also, its possible that we can monkey-patch for now in the addon. I'll investigate...

@rondale-sc
Copy link
Collaborator

It doesn't break in the test env because on the first run we manually create a lockfile in ruby and the postbuild is still able to delete it properly. This bug will only affect dev on the first change after the first first postBuild.

@rondale-sc
Copy link
Collaborator

In test we use the blocking system rather than spawn so this isn't too big a deal there.

@rwjblue
Copy link
Contributor

rwjblue commented Dec 21, 2014

rondale-sc/ember-cli-rails-addon#3 should fix the locking issue until 0.1.5 is ready for use.

@rwz rwz mentioned this issue Dec 21, 2014
Merged
rondale-sc added a commit that referenced this issue Dec 22, 2014
@rondale-sc
Bump dependency on ember-cli-rails to 0.0.5
e444ed2 
This version of the addon includes a monkeypatch that properly fires the
`preBuild` hook before build is invoked.

fixes #31
@rondale-sc rondale-sc mentioned this issue Dec 22, 2014
Merged
@rwz rwz closed this as completed in #34 Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwz rwz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump dependency on ember-cli-rails to 0.0.5 thoughtbot/ember-cli-rails
3 participants
@rwjblue @rondale-sc @rwz