-
-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chinese translation #1010
Conversation
Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW. Update zh-Hans, zh-Hant and zh-Hant-HK to use consistent Apple glossary. Complete zh-Hant-HK localisation. Correct several minor mistakes in zh-Hans, zh-Hant, and zh-Hant-HK.
I'll take your word for it :) Thanks! |
Hi, @groverlynn There seems to be a variant Chinese character (異體字) here,
And then we don't use the term Rectangle/Rectangle/zh-Hant.lproj/Main.strings Lines 374 to 377 in 9fd9e39
I'm not sure if Macau, which also uses Traditional Chinese (zh-Hant), uses the same terminology, so removing regional localization may not be a good idea. |
@ChiahongHong Thanks for pointing out these. You are absolutely right about As for zh-Hant-MO, it defaults to zh-Hant-HK which is present here. So, there should be no worries on that side. Also, there is no zh-Hant-TW or zh-Hant-MO at the MacOS system level. Unless you want to introduce Macau-specific glossary, there is really no need to create these abundant localisation which only adds burden for future updates. @rxhanson Is there anyway for these minor updates? |
I rolled those minor updates in myself, but definitely check it and make sure things look ok. |
They look okay to me. |
Great, thanks. |
Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW.
Update zh-Hans, zh-Hant and zh-Hant-HK to use consistent Apple glossary.
Complete zh-Hant-HK localisation.
Correct several minor mistakes in zh-Hans, zh-Hant, and zh-Hant-HK.