Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese translation #1010

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update Chinese translation #1010

merged 1 commit into from
Nov 30, 2022

Conversation

groverlynn
Copy link
Contributor

Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW.
Update zh-Hans, zh-Hant and zh-Hant-HK to use consistent Apple glossary.
Complete zh-Hant-HK localisation.
Correct several minor mistakes in zh-Hans, zh-Hant, and zh-Hant-HK.

Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW.
Update zh-Hans, zh-Hant and zh-Hant-HK to use consistent Apple glossary.
Complete zh-Hant-HK localisation. Correct several minor mistakes in zh-Hans, zh-Hant, and zh-Hant-HK.
@rxhanson
Copy link
Owner

Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW.

I'll take your word for it :)

Thanks!

@rxhanson rxhanson merged commit 571b9da into rxhanson:master Nov 30, 2022
@ChiahongHong
Copy link
Contributor

ChiahongHong commented Dec 1, 2022

Hi, @groverlynn

There seems to be a variant Chinese character (異體字) here, 熒幕 here should be 螢幕.

"Halves" = "一半熒幕";

And then we don't use the term 屏/屏幕 in Taiwan, and I don't think Apple's translation terminology uses it either, at least I haven't seen it on macOS or iOS.

"gHH-BV-5kP.title" = "半屏動作循環½、⅔和⅓";
/* Class = "NSMenuItem"; title = "move to adjacent on left/right, or cycle size on half"; ObjectID = "3GE-la-fAZ"; */
"3GE-la-fAZ.title" = "左/右移至相鄰,或半屏循環大小";

I'm not sure if Macau, which also uses Traditional Chinese (zh-Hant), uses the same terminology, so removing regional localization may not be a good idea.

@groverlynn
Copy link
Contributor Author

groverlynn commented Dec 1, 2022

@ChiahongHong Thanks for pointing out these.

You are absolutely right about 螢幕 instead of 熒幕. 半屏 could be replace by 一半. These should apply for both zh-Hant and zh-Hant-HK

As for zh-Hant-MO, it defaults to zh-Hant-HK which is present here. So, there should be no worries on that side. Also, there is no zh-Hant-TW or zh-Hant-MO at the MacOS system level. Unless you want to introduce Macau-specific glossary, there is really no need to create these abundant localisation which only adds burden for future updates.

@rxhanson Is there anyway for these minor updates?

@rxhanson
Copy link
Owner

rxhanson commented Dec 8, 2022

I rolled those minor updates in myself, but definitely check it and make sure things look ok.

@groverlynn
Copy link
Contributor Author

I rolled those minor updates in myself, but definitely check it and make sure things look ok.

They look okay to me.

@rxhanson
Copy link
Owner

rxhanson commented Dec 9, 2022

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants