-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ninths #702
Add ninths #702
Conversation
Thanks for opening the PR! For all new changes, I don't make any UI changes unless there's significant demand. Especially in this case, I only want to add 9 additional actions if there's a ton of people that want it, as I want to keep Rectangle as simple as I can. This also prevents us from having to do the additional work of localization and icons unless assessed necessary. So, I'm good with merging this in but only if all of the UI elements are reverted out of the storyboard, and the menu items are removed. To remove the menu items, you just set the All of the new window actions added can then just be configured via terminal commands, no further code changes necessary, similar to this one: https://github.com/rxhanson/Rectangle/blob/master/TerminalCommands.md#add-an-extra-centering-command-with-custom-size |
Screens can get pretty big these days, meaning ninths are a fairly useful standard window division. Fortunately, dividing the screen into a 3x3 grid is the same for landscape and portrait, which makes ninths a bit less complicated than sixths to implement. This does NOT include UX, but instead just provides the preference-level support for ninths hotkeys. This means ninths are available for power-users who might want them, but for now we won't clutter the UI with nine new shortcuts for anybody who folks who aren't interested in ninths.
Ah yes that makes complete sense (and makes me feel glad about the two things I hadn't done yet). I've taken the UX out of this PR (I kept it in a branch on my fork in case that UI demand crops up and it ends up being useful, though seems unlikely). Please let me know if you'd like to see any other modifications (and thank you for considering the PR) |
Oh I just realized: I should probably update the |
Ninth support has no UX but can be configured via terminal; this documentation explains to users how that can be done.
Thanks! I'm planning on rolling out a release in the next couple of days. |
Is there a way to get eights? |
@Erik262 You can create a PR just like this one for Rectangle or use Rectangle Pro and create custom shortcuts |
Thank you for this project!
I personally love ninths, as 4k screens are pretty common in the mac ecosystem and it's handy to be able to stack things like terminals. I saw in this discussion that you would be open to a PR for adding ninths to Rectangle so I thought I'd give it a whirl.
What's added
--
Note that an earlier version of this PR included UI / UX for setting shortcuts and accessing ninths via the menu. This was removed as part of the PR review, though the UI still exists in this commit if anybody is interested in that kind of thing down the line.