Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to apply gaps to the main screen only #798

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

g4rb4g3
Copy link
Contributor

@g4rb4g3 g4rb4g3 commented Apr 23, 2022

Hi there 馃憢
This PR adds another hidden preference to apply the screen gaps only to the main/primary screen.
I find it quite useful since I have uBar as dock replacement on the primary screen only. Without that the set gaps will be applied on non primary screens too which don't have any dock leaving some unused screen space.

@rxhanson
Copy link
Owner

rxhanson commented Apr 24, 2022

Thanks for contributing!

I made some updates on your fork/branch and thought that it would be automatically reflected in this PR, but it appears that it's not.

The changes are just simplifications that should have the same outcome, but I haven't tested them out. Let me know if you want me to generate a new PR if those changes seem good to you, or I could just merge this and make the changes myself.

Note that I got rid of your CG calls, as I think the NSScreen.screens.first check should be equivalent.
https://developer.apple.com/documentation/appkit/nsscreen/1388393-screens

@g4rb4g3
Copy link
Contributor Author

g4rb4g3 commented Apr 25, 2022

Thank you for the update. I'm still new to the whole Apple stuff. 馃槵
Feel free to merge everything, I can give it a try afterwards.

@rxhanson rxhanson merged commit 0b16c90 into rxhanson:master Apr 27, 2022
@rxhanson
Copy link
Owner

I merged it in and added my changes - feel free to pull the latest and try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants