Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fast dragging to Mission Control #904

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Disable fast dragging to Mission Control #904

merged 1 commit into from
Sep 8, 2022

Conversation

decodism
Copy link
Contributor

@decodism decodism commented Sep 2, 2022

Related to #902. Maybe change the sensitivity which is the -25 value?

@rxhanson
Copy link
Owner

rxhanson commented Sep 2, 2022

Nice! I'll review this one and your other pull request this weekend, and am planning on making a new release in the next week or so.

@rxhanson
Copy link
Owner

rxhanson commented Sep 5, 2022

Awesome, this looks good to me. There's only one adjustment that I'd like here, and it's that I'd like to keep the event monitor intact and be able to switch between the two implementations depending on this setting. The reason is that if an event tap gets disabled and restarted (due to the timeout case that you have properly handled here 👍), certain Macs can have an input (like a click) discarded. In my experience, event taps can be disrupted by other apps. If we only use the event tap when the user desires this functionality, it both limits the potential for a discarded input that could be caused by another app, and it makes debugging something in this category much easier to narrow down.

With that said, I'm ok with merging this in and implementing the remainder of work here myself, or I can leave it up to you - whichever you prefer.

@decodism
Copy link
Contributor Author

decodism commented Sep 6, 2022

It should be good.

@rxhanson
Copy link
Owner

rxhanson commented Sep 8, 2022

Thanks! I appreciate the follow on effort to keep the PassiveEventMonitor in place. I might readjust the checkboxes so that they are all in line.

@rxhanson rxhanson merged commit 16dd391 into rxhanson:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants