Feature/add GitHub workflow #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were part of sys/types.h, but this constellation was deprecated and now it seems to be recommended to use sys/sysmacros.h directly to get the declarations for minor()/major().
Resolution of maven bug https://issues.apache.org/jira/browse/MNG-4565 changed the behavior of profile activation triggers from logic OR to logic AND without providing fallback behavior. The new behavior leads to problems in release build for profiles which shall be automatically included in releases, but also automatically included in a development build on some build hosts for convenience reasons. Such binaries are no longer included in the release build, which is fatal. So we drop some convenience of develoment build here to ensure the sanity of our release build.
Previously, profiles were used to minimize the selected modules in the release=prepare and release=bundle use cases. This is no longer feasible if we want to use the activeByDefault profile to warn the user about a missing binary platform selection. This will result in slightly more work in the release=prepare use case, because we now also build the rxtxSerial and rxtxSerial-test modules which are not needed in this step. But I think usability is more important here. And in the long run, it might be a good idea to build and execute the tests anyway (as soon as we have some :) .
When the release bundle is created, the user does not need to select binary platforms, because the binaries are already present and are collected from the logcal maven repository.
This was referenced Apr 17, 2021
Closed
|
This is how a run looks: https://github.com/alibabashack/rxtx/actions/runs/758517810 |
Open
This was referenced May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a github actions workflow, which builds rxtx for all supported platforms and allows users to download binaries directly from github.
Only the binary for mac osx is built on a mac system. All other binaries and java parts of the library are built on a ubuntu 20.04 (via cross toolchains).