Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add GitHub workflow #32

Merged
merged 9 commits into from
May 15, 2021
Merged

Feature/add GitHub workflow #32

merged 9 commits into from
May 15, 2021

Commits on Apr 17, 2021

  1. fix implicit declaration of minor()/major() kernel calls 

    They were part of sys/types.h, but this constellation was deprecated and
now it seems to be recommended to use sys/sysmacros.h directly to get the
declarations for minor()/major().
    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    b342e23 View commit details
    Browse the repository at this point in the history

  2. fix osx compiler flags

    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    9d82b22 View commit details
    Browse the repository at this point in the history

  3. maven: upgrade plugins

    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    5151643 View commit details
    Browse the repository at this point in the history

  4. maven: fail build if a native binary is missing in release mode

    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    df1cd16 View commit details
    Browse the repository at this point in the history

  5. maven: remove automatic binary selection by os 

    Resolution of maven bug https://issues.apache.org/jira/browse/MNG-4565
changed the behavior of profile activation triggers from logic OR to logic AND
without providing fallback behavior.

The new behavior leads to problems in release build for profiles which shall be
automatically included in releases, but also automatically included in a
development build on some build hosts for convenience reasons. Such binaries
are no longer included in the release build, which is fatal.

So we drop some convenience of develoment build here to ensure the sanity of
our release build.
    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    a1e4bd1 View commit details
    Browse the repository at this point in the history

  6. maven: print informational error message if user omits binary selection

    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    3372c0b View commit details
    Browse the repository at this point in the history

  7. maven: use profiles only for binary platform selection 

    Previously, profiles were used to minimize the selected modules in the
release=prepare and release=bundle use cases. This is no longer feasible if
we want to use the activeByDefault profile to warn the user about a missing
binary platform selection.

This will result in slightly more work in the release=prepare use case,
because we now also build the rxtxSerial and rxtxSerial-test modules which are
not needed in this step. But I think usability is more important here. And in
the long run, it might be a good idea to build and execute the tests anyway
(as soon as we have some :) .
    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    1866f2b View commit details
    Browse the repository at this point in the history

  8. maven: do not require binary selection during release bundle 

    When the release bundle is created, the user does not need to select binary
platforms, because the binaries are already present and are collected from the
logcal maven repository.
    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    572584d View commit details
    Browse the repository at this point in the history

  9. add github workflow rxtx-distribution

    @alibabashack
    alibabashack committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    b5cc865 View commit details
    Browse the repository at this point in the history