Disable deno_core_http_bench_test on win32

ry · Mar 15, 2019 · f3e8cf1 · f3e8cf1
1 parent 7a6539a
commit f3e8cf1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/core/BUILD.gn b/core/BUILD.gn
@@ -4,9 +4,15 @@ group("default") {
   testonly = true
   deps = [
     ":deno_core_http_bench",
-    ":deno_core_http_bench_test",
     ":deno_core_test",
   ]
+  // deno_core_http_bench_test has a strange link error on windows.
+  // disabling for now.
+  // lld-link: error: <root>: undefined symbol: mainCRTStartup
+  // lld-link: error: undefined symbol: __CxxFrameHandler3
+  if (!is_win) {
+    deps += [ ":deno_core_http_bench_test" ]
+  }
 }
 
 # deno_core does not depend on flatbuffers nor tokio.
@@ -41,9 +47,6 @@ http_bench_extern = [
   "$rust_build:tokio",
   ":deno_core"
 ]
-if (is_win) {
-  http_bench_extern += [ "$rust_build:winapi" ]
-}
 
 rust_executable("deno_core_http_bench") {
   source_root = "http_bench.rs"
@@ -53,4 +56,7 @@ rust_executable("deno_core_http_bench") {
 rust_test("deno_core_http_bench_test") {
   source_root = "http_bench.rs"
   extern = http_bench_extern
+  deps = [
+    "../libdeno:libdeno_static_lib",
+  ]
 }
diff --git a/tools/test.py b/tools/test.py
@@ -92,8 +92,10 @@ def main(argv):
 
     deno_core_http_bench_test = os.path.join(
         build_dir, "deno_core_http_bench_test" + executable_suffix)
-    check_exists(deno_core_http_bench_test)
-    run([deno_core_http_bench_test])
+    # Note deno_core_http_bench_test is disabled on win32 at the moment.
+    if os.name != 'nt':
+        check_exists(deno_core_http_bench_test)
+        run([deno_core_http_bench_test])
 
     unit_tests(deno_exe)