Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of object paths with URL characters #38

Merged
merged 2 commits into from Nov 18, 2019
Merged

Fix rendering of object paths with URL characters #38

merged 2 commits into from Nov 18, 2019

Conversation

c-w
Copy link
Collaborator

@c-w c-w commented Nov 13, 2019

Fixes #37

This pull request URL-decodes the path we get from the Django route before doing any further manipulation. This enables us to list paths of objects that contain special URL characters such as @ which we'd otherwise represent as %40 in the path.

Screenshot showing render of object path with URL characters

ryan-roemer
ryan-roemer approved these changes Nov 18, 2019
View reviewed changes
Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@c-w c-w merged commit 5d60c02 into master Nov 18, 2019
@c-w c-w deleted the fix-url-characters branch November 18, 2019 21:24
@c-w c-w mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL characters seem to break container content listing
2 participants
@c-w @ryan-roemer