Skip to content

Fix rendering of object paths with URL characters#38

Merged
c-w merged 2 commits intomasterfrom
fix-url-characters
Nov 18, 2019
Merged

Fix rendering of object paths with URL characters#38
c-w merged 2 commits intomasterfrom
fix-url-characters

Conversation

@c-w
Copy link
Collaborator

@c-w c-w commented Nov 13, 2019

Fixes #37

This pull request URL-decodes the path we get from the Django route before doing any further manipulation. This enables us to list paths of objects that contain special URL characters such as @ which we'd otherwise represent as %40 in the path.

Screenshot showing render of object path with URL characters

Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@c-w c-w merged commit 5d60c02 into master Nov 18, 2019
@c-w c-w deleted the fix-url-characters branch November 18, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL characters seem to break container content listing

2 participants