Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of object paths with URL characters #38

Merged
merged 2 commits into from Nov 18, 2019
Merged

Conversation

@c-w
Copy link
Collaborator

c-w commented Nov 13, 2019

Fixes #37

This pull request URL-decodes the path we get from the Django route before doing any further manipulation. This enables us to list paths of objects that contain special URL characters such as @ which we'd otherwise represent as %40 in the path.

Screenshot showing render of object path with URL characters

c-w added 2 commits Nov 13, 2019
Copy link
Owner

ryan-roemer left a comment

Code changes LGTM

@c-w c-w merged commit 5d60c02 into master Nov 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@c-w c-w deleted the fix-url-characters branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.