fix args type for invokeTask (#314)

ryanatkn · Feb 11, 2022 · 639c0ea · 639c0ea
1 parent 3d0d7d8
commit 639c0ea
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,10 @@
 # changelog
 
+## 0.52.1
+
+- fix args type for `invokeTask`
+  ([#314](https://github.com/feltcoop/gro/pull/314))
+
 ## 0.52.0
 
 - **break**: validate task `args` from schemas,

diff --git a/src/task/runTask.ts b/src/task/runTask.ts
@@ -75,7 +75,7 @@ export const runTask = async (
 			events,
 			log,
 			invokeTask: (invokedTaskName, invokedArgs = {}, invokedEvents = events, invokedFs = fs) =>
-				invokeTask(invokedFs, invokedTaskName, invokedArgs, invokedEvents),
+				invokeTask(invokedFs, invokedTaskName, invokedArgs as Args, invokedEvents), // TODO typecast
 		});
 	} catch (err) {
 		return {

diff --git a/src/task/task.ts b/src/task/task.ts
@@ -19,10 +19,9 @@ export interface TaskContext<TArgs = object, TEvents = object> {
 	log: Logger;
 	args: TArgs;
 	events: StrictEventEmitter<EventEmitter, TEvents>;
-	// TODO could lookup `Args` based on a map of `taskName` types (codegen to keep it simple?)
 	invokeTask: (
 		taskName: string,
-		args?: Args,
+		args?: object,
 		events?: StrictEventEmitter<EventEmitter, TEvents>,
 		fs?: Filesystem,
 	) => Promise<void>;