Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Commit

Permalink
Merge pull request #754 from Serabe/new_authorization_bug
Browse files Browse the repository at this point in the history
Solves problem when authorizing new action.
  • Loading branch information
ryanb committed Feb 22, 2013
2 parents f1cebde + 1f7e4c8 commit 68ea78b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/cancan/controller_resource.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,11 @@ def build_resource
end

def assign_attributes(resource)
resource.send("#{parent_name}=", parent_resource) if @options[:singleton] && parent_resource
initial_attributes.each do |attr_name, value|
resource.send("#{attr_name}=", value)
end

resource.send("#{parent_name}=", parent_resource) if @options[:singleton] && parent_resource
resource
end

Expand Down
18 changes: 17 additions & 1 deletion spec/cancan/controller_resource_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,26 @@ class CustomModel
CanCan::ControllerResource.new(@controller, :category, :load => true).process
CanCan::ControllerResource.new(@controller, :project, :load => true, :through => :category).process
project = @controller.instance_variable_get(:@project)
project.new_record?.should eq(true)
project.should be_new_record
project.name.should eq('foo')
end

it "does not overrides an attribute if it is based on parent resource" do
user = double('user')
user.should_receive(:category_id).and_return nil
@ability = Ability.new user
@ability.can :new, :projects, :category_id => user.category_id
category = Category.create!
@controller.instance_variable_set(:@category, category)

@params.merge! :action => 'new', :category_id => category.id
CanCan::ControllerResource.new(@controller, :category, :load => true).process
CanCan::ControllerResource.new(@controller, :project, :load => true, :through => :category, :singleton => true).process
project = @controller.instance_variable_get(:@project)
project.category_id.should_not be_nil
project.category.should eq(category)
end

it "authorizes nested resource through parent association on index action" do
pending
@params.merge!(:action => "index")
Expand Down

0 comments on commit 68ea78b

Please sign in to comment.