This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Port fix for namespaced params from 2.0 back to 1.6 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
pushed a commit
to Sija/cancan
that referenced
this pull request
Mar 19, 2012
|
[Verified] Tests pass. I like removing references to instance_variables in preference for method calls. |
|
I like this patch but it looks like it no longer merges cleanly. If someone wants to fix I will get this pulled in. |
|
I've rebased on master and ensured all specs pass. See the referenced pull above. Recommend closing this. |
|
Closing this pull request as it is superseded by #619. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the fix for #349, but back ported to the 1.6 series. Commit: c94de4a
Probably also solves #541, #528, and #524.