Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update range() for additional features in python's range #55

Open
ryanhaining opened this issue Mar 22, 2019 · 5 comments
Open

Update range() for additional features in python's range #55

ryanhaining opened this issue Mar 22, 2019 · 5 comments
Assignees

Comments

@ryanhaining
Copy link
Owner

Give a range object r

  • r.start(), r.stop(), and r.stop() constexpr member functions to match the .start, .stop, and .step properties.
  • r.size() and r.length() to match len(r)
  • r[index]
@ryanhaining ryanhaining self-assigned this Mar 22, 2019
ryanhaining added a commit that referenced this issue Apr 14, 2019
ryanhaining added a commit that referenced this issue Apr 14, 2019
Second Part of #55. Not supporting floating point types. I can't yet
get the float version perfect.
@MatthewSteel
Copy link

Would it be against the philosophy of this project to extend range iterators with the operations required of random access iterators? (operator+, operator< etc)?

It would be nice to get log time std::lower_bound with this library, and it's technically feasible. I can send a PR if it would be welcome.

@ryanhaining
Copy link
Owner Author

There are aspects of random access iterators that can't be easily handled by range, since there isn't an underlying sequence to point to. Even having it as a ForwardIterator is sort of lying. This is not to say that you couldn't go about implementing some of the operators, but standard libraries will still use the iterator category to figure it out, and you can't update the category without implementing all of the required functions.

Look at libc++'s implementation of std::lower_bound which calls through to std::advance, which of course is implemented using tag dispatch on the iterator_category.

I've thought about reaching for more advanced iterator tags before with range, I think bidirectional is doable, but the situation is more complicated with random access.

All that said, if you would like to look for a path forward I'm happy to talk or review PRs.

@MatthewSteel
Copy link

MatthewSteel commented Jul 22, 2019

Hmm, I think the only real difficulty (though it may be insurmountable) is that the dereference operations are meant to return references, not values. All of the other operations look pretty simple.

Subclassing the trait tag with that imperfection is probably a dreadful idea, though, so I'll go another few years without a lightweight, well-maintained way to binary search over integers :-/.

Thanks for the help finding the flaw in that plan.

@ryanhaining
Copy link
Owner Author

ryanhaining commented Jul 22, 2019 via email

@MatthewSteel
Copy link

MatthewSteel commented Jul 23, 2019

I wouldnt know sorry, I was just voicing a vague hope that enough people will reinvent the wheel that one of them will turn out to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants