Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all reference type aliases to match the return type of operator* exactly. #88

Open
ryanhaining opened this issue Aug 18, 2022 · 0 comments
Open

Fix all reference type aliases to match the return type of operator* exactly. #88

ryanhaining opened this issue Aug 18, 2022 · 0 comments

Comments

@ryanhaining
Copy link
Owner

Recent libc++ checks that an iterators reference type matches its operator*'s return type. This isn't the case across itertools and must be addressed.
Testing with llvm/llvm-project@36c746c
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Adds test helper for reference correctness
e4fb185 
operator* needs to match Iterator::reference
Issue #88
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Uses ReferenceMatchesDeref in starmap test
d70c2b1 
Issue #88
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Fixes reference type in accumulate
5e8ddb3 
Issue #88
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Fixes reference type in product
038a436 
Issue #88
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Fixes reference type in zip
86e8a0c 
Issue #88
ryanhaining added a commit that referenced this issue Aug 19, 2022
@ryanhaining
Fixes reference type in slice
cc5f11f 
Issue #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanhaining