Adds :data_type option to EventbriteClient #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanj
pushed a commit
that referenced
this pull request
Jul 26, 2012
Adds :data_type option to EventbriteClient init
|
This change looks good, but you may have trouble getting the original response XML back from HTTParty, which automatically converts the result into a local object. |
|
This already works for me, I do get the raw XML response (it retains the body of the response) |
|
Ah, great - thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases I need to be able to get the XML body of the response (I need to store those for further XPath processing), therefore I needed to add an option to specify
data_typemanually. By default it will usejsonso it doesn't change default behaviour.