Skip to content

Commit

Permalink
Remove commented out code. Add compat note.
Browse files Browse the repository at this point in the history
  • Loading branch information
arohter committed Jan 9, 2014
1 parent 259b540 commit c7fea67
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions lib/redis_failover/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,12 @@ def shutdown
purge_clients
end

# Reconnect will first perform a shutdown of the underlying redis clients.
# Next, it attempts to reopen the ZooKeeper client and re-create the redis
# clients after it fetches the most up-to-date list from ZooKeeper.
# Reconnect method needed for compatibility with 3rd party libs that expect this for redis client objects.
def reconnect
#NOTE: Explicit/manual reconnects are no longer needed or desired, and
#triggered kernel mutex deadlocks in forking env (unicorn & resque) [ruby 1.9]
#Resque automatically calls this method on job fork.
#We now auto-detect underlying zk & redis client InheritedError's and reconnect automatically as needed.

#purge_clients
#@zk ? @zk.reopen : setup_zk
#build_clients
end

# Retrieves the current redis master.
Expand Down

0 comments on commit c7fea67

Please sign in to comment.