allow multiple status params for update list views

Previously, when querying a list of updates, only a
single status parameter could be specified, e.g.:

https://bodhi.fedoraproject.org/updates/?user=churchyard&status=testing

this commit changes that so multiple status parameters
can be supplied, for example:

https://bodhi.fedoraproject.org/updates/?user=churchyard&status=testing&status=pending

Related: fedora-infra#3429
Signed-off-by: Ryan Lerch <rlerch@redhat.com>

bodhi/server/schemas.py

@@ -98,6 +98,13 @@ class Updates(colander.SequenceSchema):
     update = colander.SchemaNode(colander.String())
 
 
+class Status(colander.SequenceSchema):
+    """A SequenceSchema to validate a list of Update status objects."""
+
+    status = colander.SchemaNode(colander.String(),
+                                 validator=colander.OneOf(list(UpdateStatus.values())))
+
+
 class Tests(colander.SequenceSchema):
     """A SequenceSchema to validate a list of Test objects."""
 
@@ -575,11 +582,11 @@ class ListUpdateSchema(PaginatedSchema, SearchableSchema, Cosmetics):
         validator=colander.OneOf(list(UpdateSeverity.values())),
     )
 
-    status = colander.SchemaNode(
-        colander.String(),
+    status = Status(
+        colander.Sequence(accept_scalar=True),
         location="querystring",
         missing=None,
-        validator=colander.OneOf(list(UpdateStatus.values())),
+        preparer=[util.splitter],
     )
 
     submitted_since = colander.SchemaNode(

bodhi/server/services/updates.py

@@ -346,7 +346,7 @@ def query_updates(request):
 
     status = data.get('status')
     if status is not None:
-        query = query.filter(Update.status == status)
+        query = query.filter(or_(*[Update.status == s for s in status]))
 
     submitted_since = data.get('submitted_since')
     if submitted_since is not None:

bodhi/server/validators.py

@@ -575,7 +575,12 @@ def validate_enums(request, **kwargs):
         if value is None:
             continue
 
-        request.validated[param] = enum.from_string(value)
+        if isinstance(value, str):
+            request.validated[param] = enum.from_string(value)
+        else:
+            for index, item in enumerate(value):
+                value[index] = enum.from_string(item)
+            request.validated[param] = value
 
 
 @postschema_validator