New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osx: Display not automatically updated when watch is activated and coverage file is a symlink #186
Comments
@SimonKagstrom thanks for submitting an issue, I use the vscode extension api file watchers [0] so we would have to investigate if those detect sim link file changes or not 🤔 . [0] https://code.visualstudio.com/docs/extensionAPI/vscode-api#FileSystemWatcher |
If there is an API to dereference symlinks to find the real path, I think the watch should be set there instead. The reason I use this is because of #184, where I simply symlink |
@SimonKagstrom I am not sure you need to symlink anymore if you add your |
Yes, that works. Am I supposed to edit the package.json file directly or is there some better way of configuring this? |
@SimonKagstrom I have included a gif below of how to do this but essentially what you do is go into your settings.json for vscode and modify the filenames attribute (make sure to open and close vscode to get these settings to be picked up). |
Thanks a lot for explaining via an example! Anyway, the symlink is also useful when the coverage output is placed outside of the repo (which I guess is pretty common). I typically place the output in I'll consider writing |
@SimonKagstrom with the new upcoming option to pick file paths (to individual coverage files) I am going to close this ticket. Thanks for bringing it up though! |
I'm running on OSX, with a symlink to the coverage file in my workspace (Cobertura format).
Watching is turned on, but when I update the coverage file through re-running my unit tests, the update coverage is not shown in the gutter. If I select
Coverage gutters: Display coverage
it's updated correctly again.OS: macos
Extension version: 2.2.1
VSCode version: 1.28
I also run the same project in the same way in Linux, where it seems to work.
update
: It might be because of the symlink, which I suppose is reasonable.The text was updated successfully, but these errors were encountered: