Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage commands not working anymore since last release #370

Closed
TheFabbiusCorp opened this issue May 8, 2022 · 5 comments · Fixed by #371
Closed

Coverage commands not working anymore since last release #370

TheFabbiusCorp opened this issue May 8, 2022 · 5 comments · Fixed by #371
Milestone

Comments

@TheFabbiusCorp
Copy link

Describe the bug
I have launched VSCode this morning and it seems that the extension is not working properly anymore. It doesn't show the watch button in the status bar and when I try to launch it manually it says it doesn't find the command. Here is a screenshot:

image

From my little experience with VSCode extensions, it might be due to a renaming of the commands in the latest release. Indeed, a new release has been published 14 hours ago, so maybe something has been broken there that passed the tests.

To Reproduce
Steps to reproduce the behaviour:

  1. Open VSCode palette
  2. Type "coverage watch"
  3. Click the watch command

Desktop (please complete the following information):

  • OS: macos
  • Extension Version: 2.10.0
  • VSCode Version: latest
@ilharp
Copy link
Contributor

ilharp commented May 8, 2022

+1. Downgrade to v2.9.1 solves this problem.

@ilharp
Copy link
Contributor

ilharp commented May 8, 2022

image

Oops

@ilharp
Copy link
Contributor

ilharp commented May 8, 2022

"importHelpers": true,

https://www.typescriptlang.org/tsconfig#importHelpers

Looks like we need to either turn off importHelpers in tsconfig.json or add the tslib package as runtime dep

@ryanluker
Copy link
Owner

@ilharp Thanks for the issue.
I wonder why this didn't appear when I tested locally (good info on why it happened for the unit / integration tests).
It might have only appeared when using the vsix or the compiled extenion...

I will take a look at the PR now and we can do another release right away, sorry for the disruption!

@ryanluker
Copy link
Owner

ryanluker commented May 8, 2022

I will do the release in the next hour or so after I confirm the vsix locally.
Thanks again for the ticket and the PR, it is much appreciated!

I have a ticket here where I will think on potential fixes and ways to proactively catch these kind of issues in the future.
#372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants