Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring if clause caused extension to crash #413

Closed
myverygoodusername opened this issue Jun 20, 2023 · 3 comments
Closed

refactoring if clause caused extension to crash #413

myverygoodusername opened this issue Jun 20, 2023 · 3 comments

Comments

@myverygoodusername
Copy link

Describe the bug
After some specific refactoring of a typescript method the extension stopped to work (crashed)

To Reproduce
Steps to reproduce the behaviour:

  1. Inside a method I had the following lines of code
    if( ait && ali > 1) { clp.trli = ali+1; } else { clp.trli = ali; }
  2. I changed those lines to
    clp.trli = ali; if ( ait && ( ali> 1)) clp.trli++;
  3. Afterwards I could not use the extension any longer.

Screenshots
not applicable

Desktop (please complete the following information):

  • OS: Win 11
  • Extension Version 2.11.0
  • VSCode Version 1.79.2

Additional context
not applicable

@ryanluker
Copy link
Owner

@myverygoodusername Thanks for the ticket!
Can you look into the vscode gutter logs and see if there are any error messages in there?
#389 (comment)

@myverygoodusername
Copy link
Author

myverygoodusername commented Jun 21, 2023

Dear all,

Yesterday I could reproduce the behaviour muliple times.
But today I could not do so.
The extension still works fine after the refactoring (I did again the same way).

So I think we should wait until the issue will appear again.
THX for your time and effort! And pls. close the ticket for now :)

Have a nice time and kind regards!

@ryanluker
Copy link
Owner

ryanluker commented Jun 21, 2023

Dear all,

Yesterday I could reproduce the behaviour muliple times. But today I could not do so. The extension still works fine after the refactoring (I did again the same way).

So I think we should wait until the issue will appear again. THX for your time and effort! And pls. close the ticket for now :)

Have a nice time and kind regards!

Thanks for getting back to us @myverygoodusername !
Feel free to reopen this if you catch it again + a log trail via the above link I sent yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants