Add image support for uikit feature backends #48
Conversation
| let image_bytes = include_bytes!("../../test-data/favicon.ico"); | ||
| self.image = ImageView::new(); | ||
| self.image.set_image(&Image::with_data(image_bytes)); | ||
| view.add_subview(&self.image); |
There was a problem hiding this comment.
I don't love that this is the way the iOS simulator app looks but it does show that it graphically works.
There was a problem hiding this comment.
Ha, I can write up some autolayout hell for this to make it look "nicer" once this is merged. I'd really like to get labels and listview support in, so it'd be cool to get a true "kitchen sink" iOS demo at some point here.
There was a problem hiding this comment.
Yeah. It'd be nice if it could be use similar to the other views of LayoutConstraint::activate. I agree that it should be out of the scope of this PR though.
|
This is awesome! At a glance I don't see anything I'm concerned with, but I'll likely take another look tomorrow and then look at merging. If this also makes it so I don't need to deal with #46 further then I'll close that once this gets merged as well. |
|
I've gone ahead and reviewed the That said, this could probably get merged sooner without too much hassle - just don't want to make too much extra work for @madsmtm existing PRs. (Your work is, as always, appreciated greatly!) |
| name = "defaults" | ||
| required-features = ["appkit"] | ||
| [[example]] | ||
| name = "frame_layout" |
There was a problem hiding this comment.
I'm back and forth on whether this one should disable autolayout - it's feature flagged for platforms that might not have that, but can still do frame-based layout. I think if autolayout is disabled it may also break the example at the moment, so I can PR this one after this is merged.
…well. I may break this one.
simlay
force-pushed
the
simlay/add-image-support-and-simple-unit-test
branch
from
e8300ce
to
d80b38c
Compare
|
Merged - thanks again for all of this! |
This builds off #46.
I wanted to add some simple tests so I added
Imagesupport for iOS/uikit and put a simple test in withcargo-dinghy. I'm trying to avoid too much of theobjcfor the future merge conflicts but some I'm sure will happen.The image used in the
test-datais the favicon from simlay.net because I didn't know what else to use.