Remove redundant checking for oauth_token & oauth_token_secret #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested obtaining authentication tokens? I think we did that logic because there was an issue with setting |
|
I successfully updated status from the first step that is authorizing my app by calling get_authentication_tokens() in which we don't have oauth_token, oauth_token_secret. It generated a callback as usual and everything work flawlessly after that. |
michaelhelmick
added a commit
that referenced
this pull request
Sep 12, 2015
Remove redundant checking for oauth_token & oauth_token_secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant checking for oauth_token & oauth_token_secret when using OAuth1 method from requests_oauthlib, because it is already handling None values for us.