Skip to content

Commit

Permalink
Fix Hasklug ligature removal
Browse files Browse the repository at this point in the history
[why]
Entering two consecutive vertical-bars (i.e. `||`) results in the
display of just one - the right - bar glyph.

[how]
The ligature removal is only partially implemented. The rule at work
here is not removed. There are two parts at work:

One rule to replace the first bar with nothing.

One rule to replace the second bar with a ligarture glyph with negative
left bearing, that shows two bars.

The second rule has been removed, but the first is still there.
This commit also removes the first rule.

[note]
The whole design here is broken. We remove only some rules and leave
others intact, for reasons unknown to me. Other ligartures will also be
only partially removed and leave the user with unreadable output.

We should either remove all (!) tables and not just some, or leave the
ligatures in the font.

As the ligature removal has been broken at large anyhow (see previous
commit), I would suggest to not remove any ligatures (anymore).

Fixes: #934

Reported-by: Rádler Ákos <akos.radler@gmail.com>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
  • Loading branch information
Finii committed Sep 22, 2022
1 parent 5d218b1 commit 12cd703
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/unpatched-fonts/Hasklig/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@
"Single Substitution lookup 106 subtable",
"Single Substitution lookup 107 subtable",
"Single Substitution lookup 109 subtable",
"Single Substitution lookup 110 subtable" ]
"Single Substitution lookup 110 subtable",
"Single Substitution lookup 111 subtable" ]

0 comments on commit 12cd703

Please sign in to comment.