Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Improve icons-only "Symbols Nerd Font" #479

Closed
hpfr opened this issue May 24, 2020 · 11 comments
Closed

[Suggestion] Improve icons-only "Symbols Nerd Font" #479

hpfr opened this issue May 24, 2020 · 11 comments
Milestone

Comments

@hpfr
Copy link

hpfr commented May 24, 2020

The implementation of the icons-only font in #84 is very useful, and I think it could be improved.

  1. Based on 3b5dff7, it appears the icons-only font is just a ttf file in src/glyphs. Instead of just providing the ttf in the repo, could you somehow leverage the standard patcher and just provide an empty font as input? Or maybe you could add an option to the patcher like --no-input? I'm not sure of the best way to go about it since I'm not familiar with the code, but this way, the icons-only font won't get out of date and will keep up with all the other Nerd Fonts. Right now, I think the icons-only ttf is missing the Crystal icon added in original-source.otf in 3bdc094, based on the fact that it was added 4 months ago and the ttf's are from 2 years ago. Scripting them like the other Nerd Fonts would eliminate this problem. Also, should you generate otf's instead of ttf's since they have more features? Since it's just icons, you get to choose, right? I guess you could even do both.
  2. Generate proportional and monospaced variants as with standard Nerd Fonts, i.e. "Symbols Nerd Font" and "Symbols Nerd Font Mono". This would allow users to select the proportional font for use outside of monospaced contexts (terminal emulators) to get full-size icons. For example, in window manager status bars.
  3. Provide these two font variants in the releases instead of burying them in the repo for users to find ;D.

Thank you for your work on this excellent project!

@polyzen
Copy link
Contributor

polyzen commented Jul 12, 2020

Right now, I think the icons-only ttf is missing the Crystal icon added in original-source.otf in 3bdc094, based on the fact that it was added 4 months ago and the ttf's are from 2 years ago.

This PR has the symbols fonts rebuilt for recent changes: #461

Scripting them like the other Nerd Fonts would eliminate this problem.

👍

@ryanoasis
Copy link
Owner

Yes good suggestions and you are totally right that right now they are buried and easily out dated

@hpfr
Copy link
Author

hpfr commented Mar 31, 2021

Cool, it looks like 1 and 3 will be taken care of thanks to #461 in the next release. Is that coming up anytime soon?

Does the 2048 variant address point 2? I'm guessing that's full-width non-monospaced icons?

@ryanoasis
Copy link
Owner

Is that coming up anytime soon?

😟 I don't want to promise anything, I'm catching up on PRs but yeah the releases have been really poor lately. Hoping to automate things and just release monthly or something. Since you asked

The 2048 is just the em size, good question on monospaced vs non. I believe currently both symbol only fonts are non-monospaced 🤔

@hpfr
Copy link
Author

hpfr commented Apr 11, 2021

I don't want to promise anything

No problem; I was just curious :)

currently both symbol only fonts are non-monospaced

Is it possible to make a monospaced symbols-only font? I'm interested in just installing one monospaced symbols-only font (which my terminal can fall back to from my text font) since I change monospaced fonts often and don't want to install the entire 2GB of Nerd fonts on my system.

@polyzen
Copy link
Contributor

polyzen commented Apr 11, 2021

@hpfr
Copy link
Author

hpfr commented Nov 28, 2021

Glad to see you're back working on release automation @ryanoasis. Just checking in to make sure the fixed- and double-width symbols-only fonts will be first-class citizens of the new automated GitHub Actions releases? I think this issue can be closed if that's the case.

@ryanoasis
Copy link
Owner

@hpfr hey! thanks. Actually I had forgotten about this but yeah it definitely needs to happen. Automation is key to making this monster somewhat maintainable going forward 😬

ryanoasis added a commit that referenced this issue Dec 12, 2021
@ryanoasis
Copy link
Owner

@hpfr They are basically "first-class citizens" now:

{
"unpatchedName": "Symbols Template 1000 EM",
"patchedName": "Symbols-1000-em Nerd Font Complete",
"folderName": "NerdFontsSymbolsOnly",
"imagePreviewFont": "Symbols Nerd Font",
"linkPreviewFont": false,
"description": "Just the Nerd Font Icons. I.e Symbol font only. 1000 EM size"
},
{
"unpatchedName": "Symbols Template 2048 EM",
"patchedName": "Symbols-2048-em Nerd Font Complete",
"folderName": "NerdFontsSymbolsOnly",
"imagePreviewFont": "Symbols Nerd Font",
"linkPreviewFont": false,
"description": "Just the Nerd Font Icons. I.e Symbol font only. 2048 EM size"
},
which is used to build the matrix of the fonts in the release

Selection_099

@ryanoasis ryanoasis added this to the v2.2.0 milestone Jan 10, 2022
@ryanoasis
Copy link
Owner

This ticket can be closed with 2.2.0 release as the files have been moved to the patched-fonts/ directory AND added to the release process which will build all fonts (including the symbol only ones)

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants