Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symbols-only fonts for #249 and #429 #461

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Update Symbols-only fonts for #249 and #429 #461

merged 2 commits into from
Sep 6, 2020

Conversation

polyzen
Copy link
Contributor

@polyzen polyzen commented Apr 8, 2020

Description

Updated Symbols-only fonts for #249 and #429

Requirements / Checklist

Any background context you can provide?

b9c842d#commitcomment-37240254

@polyzen
Copy link
Contributor Author

polyzen commented Apr 9, 2020

Didn't test this properly. Seems I messed something up. 🤔

@polyzen
Copy link
Contributor Author

polyzen commented Apr 9, 2020

Seems this needs to be changed to use the new Symbols Template {1000,2048} em.ttf files.

@ryanoasis
Copy link
Owner

Thanks this is definitely an oversight on the last release. To be honest I'm not sure why I had to use those template files but yeah there probably was some reason to get the symbol only fonts to generate and turn out correctly.

Did that fix what you referred to as being messed up?

I haven't had a chance to pull down the MR yet...

@polyzen
Copy link
Contributor Author

polyzen commented Apr 10, 2020

Thanks this is definitely an oversight on the last release. To be honest I'm not sure why I had to use those template files but yeah there probably was some reason to get the symbol only fonts to generate and turn out correctly.

Did that fix what you referred to as being messed up?

With the current commands listed there, the symbols were all lower (in the y axis) than they should be ┐('~`;)┌. They generated properly with:

./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/Symbols\ Template\ 1000\ em.ttf
./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/Symbols\ Template\ 2048\ em.ttf

I haven't had a chance to pull down the MR yet...

@ryanoasis
Copy link
Owner

Ah okay cool, so good then for now? Let me know if you need anything! Thanks.

@polyzen
Copy link
Contributor Author

polyzen commented Apr 10, 2020

Looks good to me, but you may want to change the commands in the Release Workflow doc.

@polyzen
Copy link
Contributor Author

polyzen commented Apr 10, 2020

Just a heads up, for some reason the 1000 em font doesn't want to work for me today.

@polyzen
Copy link
Contributor Author

polyzen commented Apr 10, 2020

No idea why it's working again, but it is.

@ryanoasis
Copy link
Owner

so to summarize:

new/correct/working:

./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/Symbols\ Template\ 1000\ em.ttf
./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/Symbols\ Template\ 2048\ em.ttf

old/incorrect:

./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/NerdFontsSymbols\ 1000\ EM\ Nerd\ Font\ Complete\ Blank.sfd
./font-patcher -ext ttf -out ./src/glyphs/ --complete ./src/glyphs/NerdFontsSymbols\ 2048\ EM\ Nerd\ Font\ Complete\ Blank.sfd

I have updated the wiki as well: https://github.com/ryanoasis/nerd-fonts/wiki/Release-Workflow#ad-hoc-updating-of-the-glyph-only-fonts

Thanks!

@polyzen
Copy link
Contributor Author

polyzen commented Apr 12, 2020

Added a commit that fixes this overlap issue in status bars:
https://bugs.archlinux.org/task/66212

@ryanoasis
Copy link
Owner

Cool, I think we could likely have this in for the next release/rebuild of all fonts if all looks good

@ryanoasis ryanoasis merged commit 8b4fca8 into ryanoasis:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants