-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hasklug: additional ligature issues #973
Comments
I'm tempted to remove to ligature removal feature altogether. Other Nerd Fonts fonts also have ligatures, and people who do not want them can usually turn them off in their client. If the client can not turn it off, it usually does not see them anyhow 馃槵 That feature requires tedious manual work, on every update 馃檮 |
Not sure if this helps, but Hasklig is essentially just Source Code Pro with ligatures. At least in this case, if someone does not want them, they can just switch to SCP. |
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: #976 Fixes: #975 Fixes: #973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: ryanoasis#976 Fixes: ryanoasis#975 Fixes: ryanoasis#973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
馃幆 Subject of the issue
Experienced behavior:
Turning ligatures on for Hasklug deletes the first character from a two char ligature:
The two issues I've found:
\\
becomes\
==
becomes=
>>
becomes*>
馃敡 Your Setup
Tried with Hasklug Nerd Font Complete Mono Windows Compatible.otf
Terminal agnostic
Using Windows
A similar issue has been solved on this ticket: #934 (that one works fine now)
The text was updated successfully, but these errors were encountered: