Sunset ligature removal #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: #976 Fixes: #975 Fixes: #973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden.
Usually if a terminal supports ligatures at all it has an option to disable them.
Present ligatures do not prevent monospaced fonts and monospaced detection.
It was only present in
v2.0.0, and the code has been broken withv2.1.0.[note]
Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit.
Fixes: #976
Fixes: #975
Fixes: #973
Requirements / Checklist
What does this Pull Request (PR) do?
Remove the ligature removal tables, so that all patched fonts still contain all ligatures that they originally had.
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)