Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adapt Homebrew Cask generation #1637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented May 16, 2024

[why]
The Cask-fonts repo has been incorporated into the main Cask repo. On releases we would use an obsolete repository to create the Cask into.

The casks are now in a dedicated subdirectory (Casks/font) and under that we have one subdirectory for each font name starting character (to have a smaller number of files per directory I assume).

[how]
Change the repository path.

Put part of the new (longer) path, the fixed part, just in the CI process, while the generator script takes care about the one-directory-per-startchar substructure.

Fixes: #1635

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Update the Cask generation and workflow to the upstream (or is that downstream) architectural changes.

How should this be manually tested?

Let the workflow run and examine the resulting PR, then close the PR :-D
Well, we need some change in our repo that causes the casks to differ or the PR will be empty.

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii Finii added the CI ⚙ Automation and release related label May 16, 2024
[why]
The Cask-fonts repo has been incorporated into the main Cask repo.
On releases we would use an obsolete repository to create the Cask into.

The casks are now in a dedicated subdirectory (Casks/font) and under that
we have one subdirectory for each font name starting character (to have a
smaller number of files per directory I assume).

[how]
Change the repository path.

Put part of the new (longer) path, the fixed part, just in the CI process,
while the generator script takes care about the one-directory-per-startchar
substructure.

Fixes: #1635

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the feature/update-cask-generation branch from 788a1f1 to b553aa8 Compare May 16, 2024 06:58
@Finii
Copy link
Collaborator Author

Finii commented May 16, 2024

Running the scripts locally looks good:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ⚙ Automation and release related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew/cask-fonts will soon be deprecated
1 participant