Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(installation): remove homebrew cask installation as it errors out #1639

Merged
merged 3 commits into from
May 19, 2024

Conversation

veritem
Copy link
Contributor

@veritem veritem commented May 18, 2024

Description

Remove homebrew cask installation

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Remove homebrew cask installation

How should this be manually tested?

Yes

Any background context you can provide?

Linked in screenshot provided

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Screenshot 2024-05-18 at 9 22 04 AM

@Finii
Copy link
Collaborator

Finii commented May 19, 2024

Thanks for the PR! 💚

Related: #1637

I overlooked that.

@Finii
Copy link
Collaborator

Finii commented May 19, 2024

@allcontributors please add @veritem for doc

Finii added 2 commits May 19, 2024 15:29
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii merged commit 0e3e1c8 into ryanoasis:master May 19, 2024
Finii added a commit that referenced this pull request May 19, 2024
[why]
See #1639

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented May 19, 2024

Also corrected download page on http://nerdfonts.com (see commit above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants