Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin icon #441

Closed
wants to merge 3 commits into from
Closed

Add Kotlin icon #441

wants to merge 3 commits into from

Conversation

andrzejressel
Copy link

@andrzejressel andrzejressel commented Feb 14, 2020

Description

Add icon for Kotlin programming language: https://kotlinlang.org/

Based on #429

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Add icon for Kotlin programming language

I found this icon in Brand section on https://icomoon.io/app/#/select/library.

Screenshots (if appropriate or helpful)

original-source.otf

image

Font in vim (Hack font)
image

When creating this PR I've realized that this icon is from this GitHub repo:
https://github.com/simple-icons/simple-icons

Here seems to be repo for font generation: https://github.com/simple-icons/simple-icons-font

@andrzejressel andrzejressel marked this pull request as ready for review February 14, 2020 23:11
@ryanoasis
Copy link
Owner

@jereksel sorry it's taken some time, please feel free to open a fresh PR now that #429 is in

@redeemefy
Copy link

@jereksel please reopen the pr.

@sicr0
Copy link

sicr0 commented Nov 11, 2021

Has the Kotlin icon been added? I can't find it in the Nerd Fonts Cheatsheet and it doesn't show up in NERDTree

@ryanoasis
Copy link
Owner

@sicr0 It has not. This dates back to when PRs had languished on the repo, things have gotten better since. I believe it was waiting for the #429 because of a codepoint conflict.

Unfortunately the codepoint where Kotlin was added is now taken up by Purescript.

We could re-open this PR and move it though...

@sicr0
Copy link

sicr0 commented Dec 12, 2021

@ryanoasis it could be nice to have Kotlin added. Also Prolog is still not added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants