Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Crystal icon #429

Merged
merged 1 commit into from
Feb 22, 2020
Merged

add Crystal icon #429

merged 1 commit into from
Feb 22, 2020

Conversation

mamantoha
Copy link
Contributor

@mamantoha mamantoha commented Jan 29, 2020

Description

Add icon for the Crystal programming language (https://crystal-lang.org)

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Add icon for the Crystal programing language.

I used IcoMoon(https://icomoon.io/app) to convert the SVG file to the font and then converted it to OTF using FontForge. And add it to original-source.otf as e52f. Also, I update font-patcher to include new icon in patched fonts.

How should this be manually tested?

Screenshots

Changes in original-source.otf

Screenshot_20200129_135930

Patched font:

Screenshot_20200129_140037

Vim with patched font:

Screenshot_20200129_140209

Let me know if I miss something.
Thanks!

Copy link
Owner

@ryanoasis ryanoasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me so far, you put the new glyph exactly where I would've expected to see it.

This will go in the next release, was right in the middle of trying to wrap up 2.1.0

I will pull your branch down and do some quick checking

@ryanoasis ryanoasis added this to the v2.2.0 milestone Feb 2, 2020
@andrzejressel andrzejressel mentioned this pull request Feb 14, 2020
5 tasks
@ryanoasis
Copy link
Owner

thanks. I think this is good to go for now!

@ryanoasis ryanoasis merged commit 3a01b84 into ryanoasis:master Feb 22, 2020
ryanoasis pushed a commit that referenced this pull request Sep 6, 2020
@andys8 andys8 mentioned this pull request Dec 6, 2020
5 tasks
@ashfinal ashfinal mentioned this pull request May 20, 2022
2 tasks
@4e554c4c 4e554c4c mentioned this pull request Sep 15, 2022
2 tasks
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants