PureScript Icon #545
Merged
PureScript Icon #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andys8
commented
Dec 6, 2020
| @@ -64,4 +64,5 @@ i='' i_custom_elm=$i | |||
| i='' i_custom_elixir=$i | |||
| i='' i_custom_electron=$i | |||
| i='' i_custom_crystal=$i | |||
| i='' i_custom_purescript=$i | |||
There was a problem hiding this comment.
Please verify this is correct, thanks
|
@ryanoasis In comparison to other pull requests based on code, I'm a bit concerned with this one (editing a font), in case it's getting stale or merge conflicts have to be resolved. I'm not sure if everything was executed correctly in the first place. I'd appreciate any feedback a lot :) |
|
Sorry for the long delay. This works well. thank you! It's been a while to be honest since I've added any glyphs but looks like you made all the necessary changes, I tested it out briefly and works well. We really should document adding glyphs to "core" but this PR is a good example 🤷🏻 |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Adds PureScript glyph/icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the PureScript logo.
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
original-source.otffont with fontforge (e530is PureScript, OpenType CFF)font-patcherHow should this be manually tested?
Have a deep look because I don't really know what I'm doing. Especially if I patched the font correctly (re-do it if in doubt) and if the correct unicode sequence is used in the
i_seti.shscript. Thank you!Any background context you can provide?
PureScript is a functional programming language like Elm or Haskell.
What are the relevant tickets (if any)?
To achieve this, I looked what a previous PR was doing: #429
The changes should be pretty similar, but for PureScript
Screenshots (if appropriate or helpful)