Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jetbrain-mono-font): installation guide #867

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix(jetbrain-mono-font): installation guide #867

merged 2 commits into from
Jul 19, 2022

Conversation

GervinFung
Copy link
Contributor

@GervinFung GervinFung commented Jul 15, 2022

Description

Update the JetBrain Mono installation guideline

Requirements / Checklist

What does this Pull Request (PR) do?

Fix the JetBrain Mono installation guideline

How should this be manually tested?

None

Any background context you can provide?

I used the command brew install --cask font-jetbrains-mono and the font displayed looks weird as shown here
Then I tried brew install --cask font-jetbrains-mono-nerd-font according to this and it works as shown right here

What are the relevant tickets (if any)?

None

Screenshots (if appropriate or helpful)

Before After
1 2

@Finii
Copy link
Collaborator

Finii commented Jul 16, 2022

The page you change is in the unpatched directory. That directory contains the original (unpatched) fonts; and the README is also the file from the unpatched/original font. Compare with its repo: https://github.com/JetBrains/JetBrainsMono

Usually in the unpatched directory everyting is 'untouched' (more or less).

Maybe you wanted to change it in the patched directory? https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/JetBrainsMono/Ligatures

How did you end up looking there for installation instructions? I'd just like to understand how people click along, and where the right spot is to intercept them. I know the docu is lacking, esp regarding packaged-by-3rd-party-stuff installation.

(My person problem is that I can not even understand WHY people might want to go the complicated route and install a font (it's just a font, come on!) with some special package software. But maybe I'm too used to get font from anywhere and just install the files with the system font install method (like: just click on it 😬))

@GervinFung
Copy link
Contributor Author

The page you change is in the unpatched directory. That directory contains the original (unpatched) fonts; and the README is also the file from the unpatched/original font. Compare with its repo: https://github.com/JetBrains/JetBrainsMono

Usually in the unpatched directory everyting is 'untouched' (more or less).

Maybe you wanted to change it in the patched directory? https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/JetBrainsMono/Ligatures

How did you end up looking there for installation instructions? I'd just like to understand how people click along, and where the right spot is to intercept them. I know the docu is lacking, esp regarding packaged-by-3rd-party-stuff installation.

(My person problem is that I can not even understand WHY people might want to go the complicated route and install a font (it's just a font, come on!) with some special package software. But maybe I'm too used to get font from anywhere and just install the files with the system font install method (like: just click on it grimacing))

Hey I updated the fix according to what you said. I used brew install because it's convenient for me, may I know what method you chose to install fonts? Perhaps its just the matter of personal preference

@Finii
Copy link
Collaborator

Finii commented Jul 19, 2022

Let me add the link to the case here:
https://github.com/Homebrew/homebrew-cask-fonts/blob/master/Casks/font-jetbrains-mono-nerd-font.rb
I also find your referenced gist of use. Hmm.
Hope I will not forget to act on this 😬

I think this is a more general problem, but you solution is at least better then before. Thank you for the PR.


How I install fonts? Usually I buy fonts for a project at MyFonts or some other retailer. Usually afterwards you can download a zip that contains the family. That is the same with free fonts, often. And like the inidividual font zip files on our Release page.
Then unzip and double click on the font files. Done. Instead of double-click you can just copy the files from the command line, if that is your workflow. No need for any font-install-manager-magic (see below).

What is harder is to keep the fonts at bay. I strive to have the minimum number of fonts installed at one time. For example I HATE all these 250? Google Noto Fonts that are autoinstalled with Ubuntu. Font chooser dialog is unusable. The first thing to uninstall after fresh setup.
A long time I used FontyPython to manage the installed fonts, but that seems to be gone. Now I use https://github.com/FontManager/font-manager, which is a no-frills solution; or I just move the files in and out of my ~/.local/share/fonts from my font storage, just with plain cp on the command line.
Unlike others I never had any issue with fc-cache and I never ever update anything there, it just works. Probably there is a icrontab set up or what, I have no clue. It just work, and I would expect modern OSes to just work.

On Windows it's the same, usually I copy directly. But sometimes Windows does not let go of a font file and you can not delete it. This different approach with file-detetion is really annoying. And Windows sometimes seems to keep old fonts cached. Well, what people say they have on Linux with fc-cache (where I never had the slightest glitch)..

Whatever! If you are still reading this.. thanks ;-)

@Finii Finii merged commit 66b41ac into ryanoasis:master Jul 19, 2022
@GervinFung
Copy link
Contributor Author

Thanks for merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants